Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distrobuilder: 2018_10_04 -> 2019_10_07 #65061

Merged
merged 1 commit into from Jul 24, 2019
Merged

distrobuilder: 2018_10_04 -> 2019_10_07 #65061

merged 1 commit into from Jul 24, 2019

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Jul 19, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mattmelling
Copy link
Contributor

nix-review pases on NixOS.

@markuskowa
Copy link
Member

@GrahamcOfBorg build distrobuilder

@markuskowa markuskowa merged commit ffabf51 into NixOS:master Jul 24, 2019
@megheaiulian megheaiulian deleted the feature/distrobuilder_10-07-2019 branch July 27, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@megheaiulian @mattmelling @markuskowa