Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #40: issue a warning on duplicate CTT entries #41

Merged
merged 1 commit into from Jul 18, 2019
Merged

Fix #40: issue a warning on duplicate CTT entries #41

merged 1 commit into from Jul 18, 2019

Conversation

Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Jul 18, 2019

waiting on test by andy

@andythenorth
Copy link
Contributor

Works as expected with repeated cargo label. Sample output follows:

nmlc -l generated/lang  --verbosity=4 --nfo=generated/iron-horse.nfo generated/iron-horse.nml
Reading lang ... 0.0 s
Reading ... 0.0 s
Init parser ... 0.4 s
Parsing ... 14.4 s
 nmlc warning: "generated/iron-horse.nml", line 102: Duplicate entry in cargo table: VEHI

@Eddi-z
Copy link
Contributor Author

Eddi-z commented Jul 18, 2019

changed the behaviour so it keeps the first value, instead of overwriting

@andythenorth
Copy link
Contributor

Updated version works as expected, keeps the first value whilst still warning.

@michicc michicc merged commit f62c56f into OpenTTD:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eddi-z @andythenorth @michicc