Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: Remove gflags dependency #64987

Merged
merged 1 commit into from Jul 25, 2019
Merged

rocksdb: Remove gflags dependency #64987

merged 1 commit into from Jul 25, 2019

Conversation

luispedro
Copy link
Contributor

@luispedro luispedro commented Jul 17, 2019 •
edited

Motivation for this change

GFlags are only used for the tools, which are not installed in any case.

According to the rocksdb docs
https://github.com/facebook/rocksdb/blob/master/INSTALL.md :

gflags - a library that handles command line flags processing. You can compile rocksdb library even if you don't have gflags installed.

Additionally, on master, the file /nix/store/nrxnwbsk869v48h868h858mx0b5sk87g-rocksdb-6.1.2/lib/cmake/rocksdb/RocksDBTargets.cmake refers to a library gflags_shared (without specifying a full path), which causes errors when trying to use rocksdb through cmake

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    Not applicable: no binaries
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Jul 20, 2019 •
edited

rocksdb itself builds fine for me on macos 10.13, reverse dependency blockbook seems to need a ulimit tweak (which I'll submit separately) to build successfully on macos.

@risicle risicle mentioned this pull request Jul 20, 2019
Merged
10 tasks
@luispedro
Copy link
Contributor Author

All reverse dependencies (including blockbook) built OK for me on Linux (not NixOS, Ubuntu).

@luispedro luispedro mentioned this pull request Jul 25, 2019
Merged
5 tasks
@luispedro @worldofpeace
rocksdb: Remove gflags dependency
f178bee 
GFlags are only used for the tools, which are not installed in any case.
@worldofpeace worldofpeace changed the title Remove gflags dependency from rocksdb rocksdb: Remove gflags dependency Jul 25, 2019
@worldofpeace worldofpeace merged commit 35d4557 into NixOS:master Jul 25, 2019
@luispedro luispedro deleted the remove_rocksdb_gflags_dep branch July 26, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luispedro @risicle @worldofpeace