Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Narrowing cast in one storybook command #7657

Merged
merged 1 commit into from Jul 18, 2019
Merged

Fix: Narrowing cast in one storybook command #7657

merged 1 commit into from Jul 18, 2019

Conversation

nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jul 17, 2019

CompanyID is 8 bit wide, so this incorrect cast would make it impossible to create story page elements for pages past 255.

@nielsmh
Fix: Narrowing cast in one storybook command
ed6fc9d 
CompanyID is 8 bit wide, so this incorrect cast would make it impossible to create story page elements for pages past 255.
@nielsmh nielsmh merged commit 331eba5 into OpenTTD:master Jul 18, 2019
@nielsmh nielsmh deleted the fix-storybook-cast branch July 18, 2019 07:36
@nielsmh nielsmh added the backport requested This PR should be backport to current release (RC / stable) label Jul 18, 2019
@nielsmh nielsmh mentioned this pull request Sep 6, 2019
Merged
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michicc michicc michicc approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nielsmh @michicc @LordAro