Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.aws-sam-translator: 1.11.0 -> 1.12.0 fix python-unstable #65003

Closed
wants to merge 1 commit into from

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Jul 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes jsonschema from previous commit #64952

cc: @worldofpeace

@jonringer
Copy link
Contributor

jonringer commented Jul 17, 2019

You may want to merge master into this... you have like 117 broken builds on python-unstable, but I fixed at least 30 or so of them on master.

@costrouc
Copy link
Member Author

costrouc commented Jul 17, 2019

That won't work becuase aws-sam-translator here depends on jsonschema >= 3. The old version is in master https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/jsonschema/default.nix

@jonringer
Copy link
Contributor

if someone has commit access, they go rebase it on top of master, probably would be a fair amount of conflicts, but then the changes in python-unstable would be applied on top of master.

@worldofpeace
Copy link
Contributor

@costrouc I think @jonringer mean't merge master into python-unstable to pickup python fixes that landed in master. But I don't think we'll get a clear picture of the failures if we do that.

@FRidh
Copy link
Member

FRidh commented Jul 18, 2019

Please don't use python-unstable. It has not been touched in quite a while.
I'll see if I can cherry-pick your existing changes or rebase them onto master.

@FRidh
Copy link
Member

FRidh commented Jul 18, 2019

Actually, better, open a new PR with the changes that went into python-unstable.

@costrouc
Copy link
Member Author

So I should move these changes and the previous PR into master?

@FRidh
Copy link
Member

FRidh commented Jul 18, 2019

Yes, master or staging depending on the amount of rebuilds.

@costrouc costrouc mentioned this pull request Jul 18, 2019
10 tasks
@costrouc
Copy link
Member Author

I will close this issue. Using #65023 instead

@costrouc costrouc closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants