Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmaintained npm2nix; node2nix is now #64913

Merged
merged 1 commit into from Jul 28, 2019
Merged

Remove unmaintained npm2nix; node2nix is now #64913

merged 1 commit into from Jul 28, 2019

Conversation

chaoflow
Copy link
Member

Motivation for this change

close #64739

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ma27
Ma27 approved these changes Jul 28, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I worked on getting rid of npm2nix builds in nixpkgs about two years ago I kept this alias for backwards compatibility in case someone uses it for personal stuff. As it's unmaintained for some time now and shouldn't be used anymore, I'm all in favor of dropping this 👍

@Ma27
Copy link
Member

Ma27 commented Jul 28, 2019

Oh and can you please resolve the merge conflict? :)

@chaoflow
Copy link
Member Author

@Ma27 Done

@chaoflow @Ma27
npm2nix: remove
10710c6 
`npm2nix` is unmaintained for about two years[1], node2nix[2] or
probably even yarn2nix[3] should be used nowadays.

[1] https://github.com/nixos/npm2nix#disclaimer-this-project-is-no-longer-maintained-instead-use-node2nix
[2] https://github.com/svanderburg/node2nix
[3] https://github.com/moretea/yarn2nix

Signed-off-by: Maximilian Bosch <maximilian@mbosch.me>
@Ma27
Copy link
Member

Ma27 commented Jul 28, 2019

Updated the commit message to match the requirements in CONTRIBUTING.md.

@Ma27 Ma27 merged commit 4fb6c02 into NixOS:master Jul 28, 2019
@Ma27
Copy link
Member

Ma27 commented Jul 28, 2019

@chaoflow thanks!

@chaoflow chaoflow deleted the remove-npm2nix branch October 8, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm2nix should be removed from nixpkgs
3 participants
@chaoflow @Ma27 @jb55