Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: init at 3.4.0 #64907

Merged
merged 1 commit into from Jul 17, 2019
Merged

cypress: init at 3.4.0 #64907

merged 1 commit into from Jul 17, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 16, 2019

Motivation for this change

cypress: init at 3.4.0

This is based on previous pull request #58423. It works fine with Electrum but not with Chromium (this is reported to upstream at cypress-io/cypress#3852) and I do not consider it a blocker to merge this package given Electrum is the main browser used in most CI.

@acyuta108 please open a pull request if you want to be added as a maintainer to this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Jul 16, 2019

@macalinao @ryantm @thorstenweber83 @acyuta108 Any opposition to merging this given the mentioned issue? At a very quick glance it looks pretty much the same as previous PR with updates.

@thorstenweber83
Copy link
Contributor

@aanderse i'm all for merging this. @mmahut ist right, electron is by far the most important browser and it works. I'm still trying to figure out how to patch the permissions issue but i'm getting nowhere atm.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging based on the good word of @thorstenweber83, and changes requested by @worldofpeace being made. The original PR really just sat around and rot. If anything doesn't work it can be addressed in another PR.

@aanderse aanderse merged commit 3910b12 into NixOS:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants