Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlang: remove wx conditional #65038

Merged
merged 1 commit into from Jul 18, 2019
Merged

erlang: remove wx conditional #65038

merged 1 commit into from Jul 18, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jul 18, 2019

The wxmac build has been fixed and there's erlang_nox now.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
erlang: remove wx conditional
574cb4a 
The wxmac build has been fixed and there's erlang_nox now.
@ofborg ofborg bot requested a review from the-kenny July 18, 2019 21:58
@LnL7 LnL7 merged commit 04b3ad8 into NixOS:master Jul 18, 2019
@LnL7 LnL7 deleted the erlang-wx branch July 18, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@LnL7