Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cups fixes #65040

Merged
merged 7 commits into from Aug 14, 2019
Merged

nixos/cups fixes #65040

merged 7 commits into from Aug 14, 2019

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Jul 18, 2019

Motivation for this change

Some changes to the NixOS CUPS module. Summaries:

  • Set CUPS_DATADIR globally
  • only enable cups service when startWhenNeeded = false
  • include /var/run/cups/cups.sock in ListenStreams
  • Disable webInterface by default (can be reenabled with webInterface = true)
  • Use socket-based activation by default.

@worldofpeace
Copy link
Contributor

@matthewbauer
Copy link
Member Author

GNOME Control Center uses CUPS_DATADIR

Oops! That is what print-manager uses as well, I had it mispelled here

@matthewbauer
Copy link
Member Author

Updated to keep the webInterface default.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

I've yet to test it.

@matthewbauer
Copy link
Member Author

@GrahamcOfBorg test printing

@matthewbauer
Copy link
Member Author

Tests are broken, need to rework it.

This is used by some programs that need CUPS data files. For instance,
print-manager looks here for printing test pages.
cups-browsed was pulling in cups.service even when we were using the
socket-based initialization.
This socket should always be created by systemd.
Make socket-based activation the
default (services.printing.startWhenNeeded)
These are now socket activated, we don’t need it to start up front.
eadwu added a commit to eadwu/nixos-configuration that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants