victor-mono: improvements from previous PR #65008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
suggested changes
Jul 18, 2019
There was a problem hiding this comment.
@dtzWill I think we're totally getting the "best of both worlds" here 鉁岋笍
(hoping someone gets this reference, probably not)
worldofpeace
approved these changes
Jul 18, 2019
dtzWill
force-pushed
the
feature/victor-mono-font
branch
2 times, most recently
from
a47594c
to
6af5c92
Compare
dtzWill
changed the title
Fixes NixOS#64465. Resolves conflicts with earlier merged PR, notable differences in the result (by our powers combined!): * provide both ttf and otf versions * quote URL, since folks seem to like those * don't put fonts in ${pname} subdirs fontconfig's hashing/cache is mostly geared for the many-fonts-in-one-place situation, although this may be fixed in more recent versions. Anyway minor change and mostly went with not modifying what I had ;) so happy to adjust back if that better matches your senses/style/use. * Drop leading 'A' from description, I think this is per policy written.. somewhere O:). * alpha-sort the meta attributes, which is easy to rem and generally matches what most expressions do anyway :) Reviewer feedback: * use subdirs with fontname, seems preferred * fix indent, whoops
worldofpeace
force-pushed
the
feature/victor-mono-font
branch
from
6af5c92
to
0cd0869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64465.
Resolves conflicts with earlier merged PR,
notable differences in the result
(by our powers combined!):
fontconfig's hashing/cache is mostly geared
for the many-fonts-in-one-place situation,
although this may be fixed in more recent versions.
Anyway minor change and mostly went with not modifying
what I had ;) so happy to adjust back if that
better matches your senses/style/use.
I think this is per policy written.. somewhere O:).
and generally matches what most expressions do anyway :)
See #64544 for previous incarnation, apparently can't reopen that one since I force-pushed? 馃槩