Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isoweek: init at 1.3.3 #64526

Merged
merged 1 commit into from Jul 17, 2019
Merged

isoweek: init at 1.3.3 #64526

merged 1 commit into from Jul 17, 2019

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Adding a new package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MrMebelMan MrMebelMan requested a review from FRidh as a code owner July 9, 2019 13:44
@xrelkd
Copy link
Contributor

xrelkd commented Jul 9, 2019 •
edited

@GrahamcOfBorg build python3Packages.isoweek

@xrelkd
Copy link
Contributor

xrelkd commented Jul 10, 2019

LGTM!
However, I do not have the privilege of merging PRs.
Please pin the maintainers. Thank you!

@MrMebelMan
Copy link
Contributor Author

Updated the commit message to include pythonPackages. as per this suggestion

@FRidh
Copy link
Member

FRidh commented Jul 17, 2019

@GrahamcOfBorg build python2.pkgs.isoweek python3.pkgs.isoweek

@FRidh FRidh merged commit 0f5e19c into NixOS:master Jul 17, 2019
@MrMebelMan MrMebelMan deleted the init/isoweek branch July 22, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrelkd xrelkd xrelkd left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrMebelMan @xrelkd @FRidh