Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libargon2: 20171227 -> 20190702 #65009

Merged
merged 1 commit into from Jul 18, 2019
Merged

libargon2: 20171227 -> 20190702 #65009

merged 1 commit into from Jul 18, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jul 18, 2019 •
edited

Motivation for this change

#64775

Thanks @jonringer!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

I'm not sure what i did :), but thanks!

@aanderse
Copy link
Member Author

Well I'm not not sure about this one:

17 package are marked as broken and were skipped:
hhvm php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 phpPackages-unit.php_excel phpPackages-unit.v8 phpPackages-unit.v8js phpPackages.php_excel phpPackages.v8 ring-daemon

1 package failed to build:
keepassxc

122 package were build:
arcanist drush icingaweb2 kcachegrind libargon2 lsp-plugins matomo nagios nextcloud-news-updater opendht phoronix-test-suite php php-embed php-unit php72 php72-embed php72-unit phpPackages-unit.apcu phpPackages-unit.apcu_bc phpPackages-unit.ast phpPackages-unit.box phpPackages-unit.composer phpPackages-unit.couchbase phpPackages-unit.event phpPackages-unit.igbinary phpPackages-unit.imagick phpPackages-unit.mailparse phpPackages-unit.memcached phpPackages-unit.oci8 phpPackages-unit.pcs phpPackages-unit.pdo_sqlsrv phpPackages-unit.php-cs-fixer phpPackages-unit.php-parallel-lint phpPackages-unit.phpcbf phpPackages-unit.phpcs phpPackages-unit.phpstan phpPackages-unit.pinba phpPackages-unit.protobuf phpPackages-unit.redis phpPackages-unit.sqlsrv phpPackages-unit.xdebug phpPackages-unit.yaml phpPackages-unit.zmq php72Packages.apcu php72Packages.apcu_bc php72Packages.ast php72Packages.box php72Packages.composer php72Packages.couchbase php72Packages.event php72Packages.igbinary php72Packages.imagick php72Packages.mailparse php72Packages.memcached php72Packages.oci8 php72Packages.pcs php72Packages.pdo_sqlsrv php72Packages.php-cs-fixer php72Packages.php-parallel-lint php72Packages.phpcbf php72Packages.phpcs php72Packages.phpstan php72Packages.pinba php72Packages.protobuf php72Packages.redis php72Packages.sqlsrv php72Packages.xdebug php72Packages.yaml php72Packages.zmq php73Packages-unit.apcu php73Packages-unit.apcu_bc php73Packages-unit.ast php73Packages-unit.box php73Packages-unit.composer php73Packages-unit.couchbase php73Packages-unit.event php73Packages-unit.igbinary php73Packages-unit.imagick php73Packages-unit.memcached php73Packages-unit.oci8 php73Packages-unit.pcs php73Packages-unit.pdo_sqlsrv php73Packages-unit.php-cs-fixer php73Packages-unit.php-parallel-lint php73Packages-unit.phpcbf php73Packages-unit.phpcs php73Packages-unit.phpstan php73Packages-unit.pinba php73Packages-unit.protobuf php73Packages-unit.redis php73Packages-unit.sqlsrv php73Packages-unit.xdebug php73Packages-unit.yaml phpPackages.apcu phpPackages.apcu_bc phpPackages.ast phpPackages.box phpPackages.composer phpPackages.couchbase phpPackages.event phpPackages.igbinary phpPackages.imagick phpPackages.memcached phpPackages.oci8 phpPackages.pcs phpPackages.pdo_sqlsrv phpPackages.php-cs-fixer phpPackages.php-parallel-lint phpPackages.phpcbf phpPackages.phpcs phpPackages.phpstan phpPackages.pinba phpPackages.protobuf phpPackages.redis phpPackages.sqlsrv phpPackages.xdebug phpPackages.yaml pulseeffects qcachegrind unit wp-cli yle-dl

And yet if I manually build:

~/nixpkgs> nix-build -A keepassxc
/nix/store/z5qrbdb6k17b9flkjpx5h6cwry012krc-keepassxc-2.4.1

🤷‍♂️

@aanderse
Copy link
Member Author

@GrahamcOfBorg build keepassxc

@aanderse
Copy link
Member Author

@s1lvester or @jonafato Are either of you able to take a look at the errors here with keepassxc?

@s1lvester s1lvester mentioned this pull request Jul 18, 2019
Merged
etu pushed a commit to etu/nixpkgs that referenced this pull request Jul 18, 2019
@s1lvester @FRidh
remove myself since I don't use this anymore, and cannot maintain it. N…
e1f2fec 
…ixOS#65009
@aanderse
Copy link
Member Author

Oh I see... looks like I needed to do a rebase on master as my last rebase has drifted far enough. Possible related to #54525 then as the error is:

qt.qpa.plugin: Could not find the Qt platform plugin "offscreen" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx.

Will look into when I get a chance.

@aanderse
Copy link
Member Author

Looked into it and keepassxc is broken on master completely unrelated to this. The keepassxc package probably just needs updating after some recent qt changes.

@aanderse aanderse merged commit 06005e8 into NixOS:master Jul 18, 2019
@aanderse aanderse deleted the libargon2 branch July 18, 2019 16:26
@jonafato
Copy link
Contributor

@aanderse For what it's worth, I've seen similar errors before with KeePassXC, and I also have an unrelated PR open at #63939 with build failures on macOS that I haven't gotten a chance to dig into. Thanks for bringing this up, I'll rebase my PR and see if that same error is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @jonringer @jonafato