Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 75.0.3770.90 -> 75.0.3770.142 #65013

Closed
wants to merge 1 commit into from
Closed

chromium: 75.0.3770.90 -> 75.0.3770.142 #65013

wants to merge 1 commit into from

Conversation

ivan
Copy link
Member

@ivan ivan commented Jul 18, 2019

Motivation for this change

Fix two CVEs: https://chromereleases.googleblog.com/2019/07/stable-channel-update-for-desktop.html

Replaces #64493.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've been running stable 75.0.3770.142 for two days on different machines and everything works fine.

Did not test beta or dev which are often broken now, anyway. I don't like how they hold up stable updates.

@andir andir requested a review from bendlas July 18, 2019 07:20
@ivan
Copy link
Member Author

ivan commented Jul 31, 2019

Obsoleted by #65633

@ivan ivan closed this Jul 31, 2019
@primeos
Copy link
Member

primeos commented Jul 31, 2019 •
edited

Chromium is becoming quite outdated now, wouldn't it make sense to merge this PR before #65633, assuming that it's already tested ("I've been running stable 75.0.3770.142 for two days on different machines and everything works fine.")?

@ivan
Copy link
Member Author

ivan commented Jul 31, 2019

I don't think so, 75 has a lot of CVEs and 76 appears to work fine, I'm just waiting for some builds to finish to confirm

@primeos primeos mentioned this pull request Jul 31, 2019
Closed
10 tasks
@primeos
Copy link
Member

primeos commented Jul 31, 2019

@ivan ok, yeah I didn't want to delay #65633 I was only concerned that Chromium would become too "outdated" in the meantime, but since the minor versions don't fix many CVEs I guess your're right and we should focus on #65633 right away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @primeos