Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron_5: fix crash when using file chooser dialog #65036

Merged
merged 1 commit into from Jul 18, 2019
Merged

electron_5: fix crash when using file chooser dialog #65036

merged 1 commit into from Jul 18, 2019

Conversation

svalaskevicius
Copy link
Contributor

@svalaskevicius svalaskevicius commented Jul 18, 2019 •
edited

Motivation for this change

Fix electron 5 crash.. same fix for the same problem as solved in #55057 , just different file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Hi @svalaskevicius, this looks perfect.

How can I test it? I don't see anything using electron_5 in nixpkgs.

@worldofpeace worldofpeace changed the title electron: fix electron 5.x crash when using file chooser dialog electron_5: fix crash when using file chooser dialog Jul 18, 2019
@svalaskevicius
Copy link
Contributor Author

svalaskevicius commented Jul 18, 2019 •
edited

@worldofpeace I've installed it locally using
nix-env -I mypkgs=/home/sarunas/src/nixpkgs/ -i -f '<mypkgs>' 'electron-5.0.0'

and then tested using a cloned version of https://github.com/jgraph/drawio-desktop
(two runs of npm install after cloning - root of the repo and the submodule - maybe just running in submodule would be enough?)

running then is electron drawio/src/main/webapp/

conveniently it has an open file dialog on the main screen to load a diagram

worldofpeace
worldofpeace approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filechooser launches for me after clearing the XDG_DATA_DIRS of the shell environment and doing #65036 (comment)

@worldofpeace worldofpeace merged commit f60744b into NixOS:master Jul 18, 2019
@svalaskevicius
Copy link
Contributor Author

That was quick! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svalaskevicius @worldofpeace