haskell: add overrides for jsaddle projects #65048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
added a commit
to reflex-frp/reflex-platform
that referenced
this pull request
Jul 19, 2019
This resolves the Upstream prs: - ghcjs/jsaddle#100 - NixOS/nixpkgs#65048
matthewbauer
force-pushed
the
haskell-jsaddle-overrides
branch
from
96ddcf5
to
30a9da5
Compare
infinisil
requested changes
Jul 19, 2019
| @@ -586,4 +586,10 @@ self: super: builtins.intersectAttrs super { | |||
| # Tests require internet | |||
| dhall_1_24_0 = dontCheck super.dhall_1_24_0; | |||
|
|
|||
| jsaddle-wkwebview = overrideCabal super.jsaddle-wkwebview (old: { | |||
| broken = false; | |||
There was a problem hiding this comment.
Remove jsaddle-wkwebview from the list of broken packages in configuration-hackage2nix.nix instead.
Ericson2314
reviewed
Jul 24, 2019
There was a problem hiding this comment.
Good to finally get this reflex-platform stuff in nixpkgs! @infinisil raises a good point but otherwise looks good.
CC @dmjio
Ericson2314
added
the
9.needs: port to stable
|
I marked port to stable. It is harmless to fix broken packages on a release branch I think, and good shrink reflex-platform before the switch to 19.06. |
|
Note that webkitgtk stuff is still broken due to some weird version incompatibilities in the latest haskell packages update. Hopefully will resolve in a newer version. |
peti
requested changes
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)