Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.zarr: init at 2.3.2 #65027

Merged
merged 2 commits into from Jul 22, 2019
Merged

Conversation

costrouc
Copy link
Member

Motivation for this change

Awesome Scipy talk on zarr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.zarr python3Packages.zarr

@costrouc costrouc changed the title [WIP] pythonPackages.zarr: init at 2.3.2 pythonPackages.zarr: init at 2.3.2 Jul 18, 2019
@costrouc
Copy link
Member Author

Build passes ready for merge

@smaret
Copy link
Member

smaret commented Jul 18, 2019

Built successfully on Darwin with nix review.

@risicle
Copy link
Contributor

risicle commented Jul 18, 2019

Must have been quite some conference. nox-review checks out for me non-nixos linux x86_64.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

@FRidh
Copy link
Member

FRidh commented Jul 19, 2019

I "borrowed" these commits for a demo repo at https://github.com/FRidh/flake-python-science/tree/master.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.zarr python3Packages.zarr

@costrouc
Copy link
Member Author

Ready for merge this is has been tested on osx and linux with all tests and passes

@FRidh FRidh merged commit 62cb4f7 into NixOS:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants