mesa: build iris #65017

colemickens · 2019-07-18T08:30:12Z

Motivation for this change

Things done

colemickens · 2019-07-18T08:33:53Z

I'm not sure this change will work. I don't know meson's build language semantics exactly, but it looks like it overrides the list of drivers completely, if auto is included in the list... https://gitlab.freedesktop.org/mesa/mesa/blob/master/meson.build#L142

EDIT: Ref: #63912 <- this PR removed the logic to determine which drivers to build. I guess we would have to reinstate most of that in order to build iris. It would be nice if upstream would allow ["auto" "iris"] as a way to say "build defaults + iris" but my test build indicates that is not how it works currently.

EDIT2: I'm going to try and patch the meson.build to see if I can get it to add the defaults to the list of gallium drivers instead of replacing the list, thus allowing auto+extras. Not sure though, since auto will still be in the list of drivers and presumably there's not actually a gallium driver named 'auto' to build...

colemickens · 2019-07-18T08:33:59Z

cc: @worldofpeace

colemickens · 2019-07-18T09:02:04Z

Alright, somehow this works, even though its not pretty. I'm going to build my system with this change and I'll report back.

matthewbauer · 2019-07-18T15:44:33Z

pkgs/development/libraries/mesa/default.nix

@@ -5,7 +5,7 @@
 , libelf, libvdpau, python3Packages
 , libglvnd
 , enableRadv ? true
-, galliumDrivers ? ["auto"]
+, galliumDrivers ? ["auto" "iris" ]


"iris" should just be built on linux

#65017 (comment)

colemickens · 2019-07-18T16:45:08Z

It's not. I've confirmed myself and it's clear from reading the meson.build that it's not.

…

On Thu, Jul 18, 2019, 17:44 Matthew Bauer ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkgs/development/libraries/mesa/default.nix <#65017 (comment)>: > @@ -5,7 +5,7 @@ , libelf, libvdpau, python3Packages , libglvnd , enableRadv ? true -, galliumDrivers ? ["auto"] +, galliumDrivers ? ["auto" "iris" ] "iris" should just be built on linux — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#65017?email_source=notifications&email_token=AACP25BLCYVO74D25RHRBJTQACFW7A5CNFSM4IEYG2E2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB64HM5I#pullrequestreview-263747189>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACP25BR6UBPP4YCXENXWELQACFW7ANCNFSM4IEYG2EQ> .

matthewbauer · 2019-07-18T18:16:17Z

@colemickens Was iris built before #63912? If so, we definitely should make sure it stays the same. Otherwise, though, I would prefer to defer to what mesa includes by default. The alternative is that you can build these drivers yourself and add them to opengl extraPackages:

{ pkgs, ... }:
let
  iris = (pkgs.mesa.override {
    galliumDrivers = ["iris"];
    driDrivers = [];
    vulkanDrivers = [];
  });
in {
  hardware.opengl.extraPackages = [ iris ];
}

worldofpeace · 2019-07-18T18:25:24Z

I think it's perfectly sensible to be able to build iris, and defer to what upstream has as defaults.

The alternative is that you can build these drivers yourself and add them to opengl extraPackages:

Iris is highly desirous atm so I wouldn't want users to just have to do that.

colemickens · 2019-07-18T19:01:51Z

I'm fine with building it myself, especially if I don't have to build the world. I'd be happy to document it on the wiki as well. However, I haven't found an override that works yet...

Trying with

  (pkgs.mesa.override {
    galliumDrivers = ["iris"];
    driDrivers = [];
    vulkanDrivers = [];
  });

Native C compiler: /nix/store/b8kdniwlxcppnsil2mq347aibf9hpm5d-gcc-wrapper-7.4.0/bin/cc (gcc 7.4.0 "gcc (GCC) 7.4.0")
Native C++ compiler: /nix/store/b8kdniwlxcppnsil2mq347aibf9hpm5d-gcc-wrapper-7.4.0/bin/c++ (gcc 7.4.0 "g++ (GCC) 7.4.0")
Build machine cpu family: x86_64
Build machine cpu: x86_64
Program pkg-config found: YES (/nix/store/k4k297jyxk2hnhdykdz3mf3lxmmh52rb-pkg-config-0.29.2/bin/pkg-config)

meson.build:647:4: ERROR: Problem encountered: The nine state tracker requires gallium softpipe/llvmpipe.

A full log can be found at /build/mesa-19.1.1/build/meson-logs/meson-log.txt
builder for '/nix/store/bdzjm2s84zgpab0153pbbclr5hhc5inm-mesa-19.1.1.drv' failed with exit code 1
cannot build derivation '/nix/store/njpvcn8jg77rv9ca7p29hmi69q23r18x-opengl-drivers.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vi050hsljmrj6ajy8ib31375360mxww2-etc-nixos.conf.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rccf1npijdky3l42zinw8vndbkddfxdd-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dmyliy2fcrj0raz1677p60qr0ajw53kn-nixos-system-xeep-19.09.git.git.drv': 1 dependencies couldn't be built
error: build of '/nix/store/dmyliy2fcrj0raz1677p60qr0ajw53kn-nixos-system-xeep-19.09.git.git.drv' failed
+ toplevel=

Trying with

  (pkgs.mesa.override {
    galliumDrivers = ["iris" "swrast "virgl" ];
    driDrivers = [];
    vulkanDrivers = [];
  });

Installing /build/mesa-19.1.1/build/meson-private/egl.pc to /nix/store/33vawb681frlh30m14zjva20kij72yw8-mesa-19.1.1/lib/pkgconfig
Installing /build/mesa-19.1.1/build/meson-private/osmesa.pc to /nix/store/33vawb681frlh30m14zjva20kij72yw8-mesa-19.1.1/lib/pkgconfig
Installing /build/mesa-19.1.1/build/meson-private/d3d.pc to /nix/store/33vawb681frlh30m14zjva20kij72yw8-mesa-19.1.1/lib/pkgconfig
Installing /build/mesa-19.1.1/build/meson-private/gl.pc to /nix/store/33vawb681frlh30m14zjva20kij72yw8-mesa-19.1.1/lib/pkgconfig
Running custom install script '/nix/store/7q2pgxz0yhf8b3dywq67x5m41gmhsagh-python3-3.7.3/bin/python3.7 /build/mesa-19.1.1/bin/install_megadrivers.py /build/mesa-19.1.1/build/src/gallium/targets/dri/libgallium_dri.so /nix/store/890sg02rppirhjk35ilk8zs7kqplpisz-mesa-19.1.1-drivers/lib/dri swrast_dri.so kms_swrast_dri.so iris_dri.so virtio_gpu_dri.so'
mv: missing file operand
Try 'mv --help' for more information.
builder for '/nix/store/f1vzhpzyg6s861iynl09mchsr8xh49kz-mesa-19.1.1.drv' failed with exit code 1
cannot build derivation '/nix/store/gwji4kq7rnz4z67j4k0pnzipd6j53hch-opengl-drivers.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5x2xyb0pnyn6s92278qgn59s1p8xn3x3-etc-nixos.conf.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/25rf2r6nah2l7dmsc2gcy3ahaby6sq6l-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cplgh5rmypqhxr27dyhyfaxlfwflwf0i-nixos-system-xeep-19.09.git.git.drv': 1 dependencies couldn't be built
error: build of '/nix/store/cplgh5rmypqhxr27dyhyfaxlfwflwf0i-nixos-system-xeep-19.09.git.git.drv' failed

Trying with

  (pkgs.mesa.override {
    galliumDrivers = ["iris" "swrast "virgl" ];
  });

shrinking /nix/store/araywhc9s59jrnd7q5mrgl5kjm6vj0jr-mesa-19.1.1-drivers/lib/libEGL_mesa.so.0.0.0
shrinking /nix/store/araywhc9s59jrnd7q5mrgl5kjm6vj0jr-mesa-19.1.1-drivers/lib/d3d/d3dadapter9.so.1.0.0
strip is /nix/store/glhymgljg23hkyii6dgc5b276ajafm2x-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/araywhc9s59jrnd7q5mrgl5kjm6vj0jr-mesa-19.1.1-drivers/lib
patching script interpreter paths in /nix/store/araywhc9s59jrnd7q5mrgl5kjm6vj0jr-mesa-19.1.1-drivers
checking for references to /build/ in /nix/store/araywhc9s59jrnd7q5mrgl5kjm6vj0jr-mesa-19.1.1-drivers...
shrinking RPATHs of ELF executables and libraries in /nix/store/2nvg25k83ykd5v3rzh1lrskhaspa63sm-mesa-19.1.1-osmesa
shrinking /nix/store/2nvg25k83ykd5v3rzh1lrskhaspa63sm-mesa-19.1.1-osmesa/lib/libOSMesa.so.8.0.0
strip is /nix/store/glhymgljg23hkyii6dgc5b276ajafm2x-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2nvg25k83ykd5v3rzh1lrskhaspa63sm-mesa-19.1.1-osmesa/lib
patching script interpreter paths in /nix/store/2nvg25k83ykd5v3rzh1lrskhaspa63sm-mesa-19.1.1-osmesa
checking for references to /build/ in /nix/store/2nvg25k83ykd5v3rzh1lrskhaspa63sm-mesa-19.1.1-osmesa...
substitute(): ERROR: file '/nix/store/rpglpf0b6lhn6yzd8j320m9y6nnqhxhs-mesa-19.1.1-dev/lib/pkgconfig/xatracker.pc' does not exist
builder for '/nix/store/g55qi27yba1kvj1h6lighr8q2jxfh29l-mesa-19.1.1.drv' failed with exit code 1
cannot build derivation '/nix/store/a7w7vi5yj51vgg5f11mmlmyhflv0as66-opengl-drivers.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f4gxr49m9dv3vlhxil75kskws05ip0ha-etc-nixos.conf.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/520x3laaiyac2an1hcwn683srhirpa8b-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k0v200857268hhyly82l61abl1a5k6zh-nixos-system-xeep-19.09.git.git.drv': 1 dependencies couldn't be built
error: build of '/nix/store/k0v200857268hhyly82l61abl1a5k6zh-nixos-system-xeep-19.09.git.git.drv' failed
+ toplevel=

colemickens · 2019-07-18T19:46:07Z

Looks like the Nix derivation always copies the XA state tracker pkg-config, and it looks like mesa's meson.build only builds it when certain gallium drivers are included. I'm not sure if this is intentional, or an oversight on upstream's part when they added iris. I've asked in #dri-devel.

This seems to build, at least:

(pkgs.mesa.override {
   galliumDrivers = [ "r300" "r600" "radeonsi" "nouveau" "virgl" "svga" "swrast" "swrast" "virgl" "iris" ];
})

However, after system activation, I see this:

[cole@xeep:/run/opengl-driver/lib/dri]$ ls /nix/store/w36z32hx86xxxbbdpbkanf42gi0sn9q9-mesa-19.1.1-drivers/lib/dri | rg iris
iris_dri.so

[cole@xeep:/run/opengl-driver/lib/dri]$ ls /run/opengl-driver/lib/dri | rg iris

colemickens · 2019-07-18T19:59:44Z

cc: @eadwu

eadwu · 2019-07-18T20:49:53Z

Before #63912, iris wasn't built by default. Currently, iris is in a usable state and only by 19.2 should be a viable replacement is what I've read they're aiming for. Personally I haven't experienced any major problems when I used iris in my daily life. The only problem I've actually encountered with iris is with compton which seems to be because of missing GLX extensions.

I'd probably expect iris to be built with auto on supported generations in the future when they finish it up. The way I've been overriding mesa was just copying over the drivers listed in the configuration summary of the build log and prepending iris.

Adding it to hardware.opengl.extraPackages seems to do the trick though it ends up adding more useless libraries to /run/opengl-drivers in my configuration. Is hardware.opengl.s3tcSupport needed anymore since it seems like it was incorporated into mesa? If not then setting hardware.opengl.package = lib.mkDefault (mesa.override { }).drivers; seems like the best solution in my eyes.

/run/opengl-drivers is created by tmpfiles so rebooting would fix the path. Restarting one of the systemd-tmpfiles-* might also do the trick?

colemickens · 2019-07-18T21:09:51Z

I made this change to my system nixos configuration: colemickens/nixcfg@6a05bda. I rebuilt, and rebooted, and there is still no iris available for me: tree /run/opengl-driver | grep iris -> no results.

eadwu · 2019-07-18T21:11:35Z

You want the $drivers output.

colemickens · 2019-07-18T21:15:54Z

Thanks for the fast response. Next try: colemickens/nixcfg@a8a0f80

Now I get a collision:

these derivations will be built:
  /nix/store/sqnk6c4np671jgvy6hd3wz3hzvclm7ys-opengl-drivers.drv
  /nix/store/vd5lmbmrbx9hf62bjqw3ib5fzcs83r1k-etc-nixos.conf.drv
  /nix/store/r8iyxcdhqx0m39gciwwyhs96nbfh338y-etc.drv
  /nix/store/vh4vblck4216xbsr2lcf8z4zns255rl5-nixos-system-xeep-19.09.git.git.drv
building '/nix/store/sqnk6c4np671jgvy6hd3wz3hzvclm7ys-opengl-drivers.drv'...
collision between `/nix/store/fpbfc4qmzzywnkxl8mqszpqy8bzmp413-mesa-19.1.1-drivers/lib/libGLX_mesa.so.0.0.0' and `/nix/store/f70lgq6yzjybjazkrjpwayhpldgb7681-mesa-drivers+txc-19.1.1/lib/libGLX_mesa.so.0.0.0'
builder for '/nix/store/sqnk6c4np671jgvy6hd3wz3hzvclm7ys-opengl-drivers.drv' failed with exit code 255

I feel like I ought to know how to get past this, at this point in my NixOS usage. :/

eadwu · 2019-07-18T21:18:52Z

Probably can be solved by setting the priority? Though I would rather use hardware.opengl.package once I make sure about the s3tcSupport option.

colemickens · 2019-07-18T21:39:14Z

cool, this works: colemickens/nixcfg@5307eca

I am far from an expert, but from what I'm reading we can remove the s3tc stuff: https://arch-dev-public.archlinux.narkive.com/ApEYtwBN/removal-of-lib32-libtxc-dxtn-and-libtxc-dxtn-from-repositories

colemickens · 2019-07-18T21:43:23Z

(Thank you very much for the guidance @eadwu).

I'm going to go ahead and close this for now. Here's a wiki entry: https://nixos.wiki/wiki/Intel_Graphics (we can correct it if we turn out to be wrong about s3tc stuff, but I figure it can't matter much since it's disabled by default anyway).

worldofpeace · 2019-07-19T01:39:35Z

@colemickens The example you put in the wiki doesn't point to the drivers output.

colemickens · 2019-07-19T07:50:23Z

Fixed. Thanks @worldofpeace

ilya-fedin · 2020-01-17T04:27:39Z

Can this PR be reopened? It would be nice if mesa with the iris driver will be as a separate entry in all-packages.nix at least. Mesa builds for a very long time on my hardware (Celeron N4000, yes). :(

vcunat · 2020-02-01T09:45:39Z

Upstream is even defaulting to iris on some HW. It will be in mesa >= 20, currently in RC1 phase, so we should soon get it anyway.

ilya-fedin · 2020-02-01T10:36:58Z

Okay, that's good news

ofborg bot requested a review from vcunat July 18, 2019 08:42

ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Jul 18, 2019

mesa: build iris

e66408a

colemickens changed the base branch from master to staging July 18, 2019 09:01

colemickens force-pushed the mesa-iris branch from aadef2a to e66408a Compare July 18, 2019 09:01

matthewbauer reviewed Jul 18, 2019

View reviewed changes

eadwu mentioned this pull request Jul 18, 2019

treewide: mesa.drivers -> mesa_drivers #64599

Closed

10 tasks

colemickens closed this Jul 18, 2019

colemickens deleted the mesa-iris branch July 18, 2019 21:50

colemickens mentioned this pull request Jul 18, 2019

mesa: cleanup s3tc + make gallium-xa pkg-config optional #65039

Closed

d4g mentioned this pull request Sep 4, 2020

using mesa iris I get the error "kernel to old" #97103

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mesa: build iris #65017

mesa: build iris #65017

colemickens commented Jul 18, 2019 •

edited

colemickens commented Jul 18, 2019 •

edited

colemickens commented Jul 18, 2019

colemickens commented Jul 18, 2019

matthewbauer Jul 18, 2019

worldofpeace Jul 18, 2019

colemickens commented Jul 18, 2019 via email

matthewbauer commented Jul 18, 2019

worldofpeace commented Jul 18, 2019

colemickens commented Jul 18, 2019 •

edited

colemickens commented Jul 18, 2019

colemickens commented Jul 18, 2019

eadwu commented Jul 18, 2019 •

edited

colemickens commented Jul 18, 2019

eadwu commented Jul 18, 2019

colemickens commented Jul 18, 2019

eadwu commented Jul 18, 2019

colemickens commented Jul 18, 2019

colemickens commented Jul 18, 2019

worldofpeace commented Jul 19, 2019

colemickens commented Jul 19, 2019

ilya-fedin commented Jan 17, 2020 •

edited

vcunat commented Feb 1, 2020

ilya-fedin commented Feb 1, 2020

mesa: build iris #65017

mesa: build iris #65017

Conversation

colemickens commented Jul 18, 2019 • edited

Motivation for this change

Things done

colemickens commented Jul 18, 2019 • edited

colemickens commented Jul 18, 2019

colemickens commented Jul 18, 2019

matthewbauer Jul 18, 2019

Choose a reason for hiding this comment

worldofpeace Jul 18, 2019

Choose a reason for hiding this comment

colemickens commented Jul 18, 2019 via email

matthewbauer commented Jul 18, 2019

worldofpeace commented Jul 18, 2019

colemickens commented Jul 18, 2019 • edited

colemickens commented Jul 18, 2019

colemickens commented Jul 18, 2019

eadwu commented Jul 18, 2019 • edited

colemickens commented Jul 18, 2019

eadwu commented Jul 18, 2019

colemickens commented Jul 18, 2019

eadwu commented Jul 18, 2019

colemickens commented Jul 18, 2019

colemickens commented Jul 18, 2019

worldofpeace commented Jul 19, 2019

colemickens commented Jul 19, 2019

ilya-fedin commented Jan 17, 2020 • edited

vcunat commented Feb 1, 2020

ilya-fedin commented Feb 1, 2020

colemickens commented Jul 18, 2019 •

edited

colemickens commented Jul 18, 2019 •

edited

colemickens commented Jul 18, 2019 •

edited

eadwu commented Jul 18, 2019 •

edited

ilya-fedin commented Jan 17, 2020 •

edited