Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wavpack: CVE-2018-19840 CVE-2018-19841 #64917

Merged
merged 2 commits into from Jul 16, 2019
Merged

wavpack: CVE-2018-19840 CVE-2018-19841 #64917

merged 2 commits into from Jul 16, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 16, 2019 •
edited

Motivation for this change

Fixes #64664.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vcunat added a commit that referenced this pull request Jul 16, 2019
@vcunat
Merge #64917: wavpack: CVE-2018-19840 CVE-2018-19841
12d7fb5 
(cherry picked from commit 5777f52)
@vcunat vcunat merged commit 71a3753 into NixOS:master Jul 16, 2019
vcunat added a commit that referenced this pull request Jul 16, 2019
@vcunat
Merge #64917: wavpack: CVE-2018-19840 CVE-2018-19841
5777f52
@mmahut mmahut deleted the wavpack branch July 16, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 72: wavpack-5.1.0: 2 advisories
2 participants
@mmahut @vcunat