Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mwparserfromhell: init at 0.5.4 #64942

Merged
merged 2 commits into from Jul 17, 2019
Merged

pythonPackages.mwparserfromhell: init at 0.5.4 #64942

merged 2 commits into from Jul 17, 2019

Conversation

mattmelling
Copy link
Contributor

Motivation for this change

A Python parser for MediaWiki wikicode. mwparserfromhell is listed as a pip dependency for the existing textacy package.

Things done
  • Created new package for mwparserfromhell
  • Added self as maintainer
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mattmelling mattmelling requested a review from FRidh as a code owner July 16, 2019 20:00
@FRidh
Copy link
Member

FRidh commented Jul 17, 2019

@GrahamcOfBorg build python.pkgs.mwparserfromhell python3.pkgs.mwparserfromhell

@FRidh FRidh merged commit 6c9d4bc into NixOS:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattmelling @FRidh