Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-helm: 2.11 -> 2.14.1 #64979

Merged
merged 2 commits into from Jul 20, 2019
Merged

Conversation

edude03
Copy link
Contributor

@edude03 edude03 commented Jul 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edude03
Copy link
Contributor Author

edude03 commented Jul 17, 2019

@markus1189 @teozkr @nlewo @yurrriq, updates helm while still built from source, fixes the version issue raised in #56837

@mmahut
Copy link
Member

mmahut commented Jul 17, 2019

@GrahamcOfBorg build kubernetes-helm

@nightkr
Copy link
Member

nightkr commented Jul 17, 2019

That's a peculiar definition of friday! :D

@markus1189
Copy link
Contributor

markus1189 commented Jul 17, 2019 via email

@@ -1,14 +1,14 @@
{ stdenv, buildGoPackage, fetchFromGitHub }:

buildGoPackage rec {
version = "2.11.0";
version = "2.14.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do 2.14.2

@yurrriq
Copy link
Member

yurrriq commented Jul 17, 2019

Any tips on how you got dep init and vgo2nix to work well here? In my experience it would seemingly hang for hours before I gave up.

@risicle
Copy link
Contributor

risicle commented Jul 19, 2019

nox-review builds, binaries execute on macos 10.13.

@andir
Copy link
Member

andir commented Jul 20, 2019

This would also fix CVE-2019-1000008. And if people using helm thinks it is alright also a backport.

@andir andir merged commit bd7f9b6 into NixOS:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants