Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: Fix desktop icon #65042

Merged
merged 1 commit into from Jul 19, 2019
Merged

discord: Fix desktop icon #65042

merged 1 commit into from Jul 19, 2019

Conversation

benley
Copy link
Member

@benley benley commented Jul 18, 2019

Motivation for this change

The name used in the .desktop file needs to match the filename that exists in $out/share/pixmaps/ for it to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley
discord: Fix desktop icon
24724da 
The name used in the .desktop file needs to match the filename that
exists in $out/share/pixmaps/ for it to work.
@ofborg ofborg bot requested a review from MP2E July 18, 2019 23:11
@teto teto merged commit 59b08e6 into NixOS:master Jul 19, 2019
@benley benley deleted the benley/discord-desktop-icon branch July 19, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benley @teto