Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b2e0ab39a740
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 3e25412e3b74
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jul 18, 2019

  1. victor-mono: improvements from previous PR 

    Fixes #64465.

Resolves conflicts with earlier merged PR,
notable differences in the result
(by our powers combined!):

* provide both ttf and otf versions
* quote URL, since folks seem to like those
* don't put fonts in ${pname} subdirs
  fontconfig's hashing/cache is mostly geared
  for the many-fonts-in-one-place situation,
  although this may be fixed in more recent versions.
  Anyway minor change and mostly went with not modifying
  what I had ;) so happy to adjust back if that
  better matches your senses/style/use.
* Drop leading 'A' from description,
  I think this is per policy written.. somewhere O:).
* alpha-sort the meta attributes, which is easy to rem
  and generally matches what most expressions do anyway :)

Reviewer feedback:

* use subdirs with fontname, seems preferred
* fix indent, whoops
    @dtzWill @worldofpeace
    dtzWill authored and worldofpeace committed Jul 18, 2019
    Copy the full SHA
    0cd0869 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #65008 from dtzWill/feature/victor-mono-font 

    victor-mono: improvements from previous PR
    @worldofpeace
    worldofpeace committed Jul 18, 2019
    Copy the full SHA
    3e25412 View commit details
    Browse the repository at this point in the history