Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video2midi: 0.3.7 -> 0.3.9.1 #64993

Merged
merged 1 commit into from Jul 20, 2019
Merged

video2midi: 0.3.7 -> 0.3.9.1 #64993

merged 1 commit into from Jul 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2019 •
edited by ghost

Motivation for this change

Also move to python-packages, since it supports Python 3 now too.

nix-build -A video2midi -A python2Packages.video2midi -A python3Packages.video2midi

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from FRidh as a code owner July 17, 2019 17:50
@worldofpeace
Copy link
Contributor

I don't understand why this was moved to python-packages.nix that's for python modules and this is an application.

@ghost
Copy link
Author

ghost commented Jul 19, 2019

@worldofpeace

I don't understand why this was moved to python-packages.nix that's for python modules and this is an application.

I thought it would be nice to build both python2 and python3 variants, but if not, I will make it back and python3 only

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 19, 2019 •
edited

If you wanted to do that you could just have an attribute in all-packages.nix that overrides the python version.

video2midi-python2 = video2midi.override { python3 = python; };

but for an application I'd think that would be unneeded.

@ghost
Copy link
Author

ghost commented Jul 20, 2019

@jonringer @worldofpeace Thanks! Is it fine now?

@ofborg ofborg bot removed the 6.topic: python label Jul 20, 2019
@worldofpeace worldofpeace merged commit bacce59 into NixOS:master Jul 20, 2019
@ghost
Copy link
Author

ghost commented Jul 20, 2019

@worldofpeace Thanks!

@ghost ghost deleted the video2midi branch July 20, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jonringer