@GrahamcOfBorg build python3Packages.rotate-backups

Since this is an application AFAIU, I'd suggest adding an alias at the top level.

@lheckemann I will look into it! Some of the dependencies like coloredlogs is also a application.. Will check which are and which aren't :)

for converting a python libray to an application, just create the library as a python-module, then in all-packages.nix you can do something to the effect of:

rotate-backups = with python3Packages; toPythonApplication rotate-backups;

@jonringer should incoperate everything you asked, and also @lheckemann should have added all which are applications. :)

for adhering to the CONTRIBUTING.md, I think people expect that 1 commit relates to all changes for a given package. Although the little "auto commit changes" feature is nice in github, it does make the commit history polluted with a bunch of small commits.

I think it's prefered to do all the changes i suggested to their related commit, or at the very least, squash all the tiny commits into one that makes sense. I'm sure someone else will have a stronger opinion on the matter.

coloredlogs tests fail on py37 on macos 10.13. I'll take a look at getting them working...

I've opened a PR upstream (xolox/python-coloredlogs#74), so coloredlogs just needs:

  patches = lib.optional (stdenv.isDarwin && isPy3k) (fetchpatch {
    name = "darwin-py3-capture-fix.patch";
    url = "https://github.com/xolox/python-coloredlogs/pull/74.patch";
    sha256 = "0pk7k94iz0gdripw623vzdl4hd83vwhsfzshl8pbvh1n6swi0xx9";
  });

After that nox-review is happy on macos 10.13 & non-nixos linux x86_64.

Should be good to go now :)

@GrahamcOfBorg build pythonPackages.rotate-backups

Why are the python-modules being called in all-packages.nix?
That is something we should never be doing, unless it's to alias an application as @jonringer mentioned.

@worldofpeace the packages that is aliased in all-packages.nix are command line applications :)

EDIT: Note that it is not all modules that are in all-packages.nix

@worldofpeace should be fixed now!

Fixed, should be good to go now :)