Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This pull request incorporates ideas from #63843 and #63620. It intends to upgrade Mathematica to 12.0.0.
I tried many many ways to adopt
autoPatchelfHook
, and all of them failed. Some definitions require old packages that are missing/already obsolete in Nixpkgs and hence cannot be built. Some definitions can be built, but the resulting executable either fails to run by relocation error, or crashes by segmentation fault. Also, manually debugging definitions is a rather painful process: every change typically requires 10-20 minutes of building, and it is not guaranteed to be successful.Thus IMHO keeping the current
preFixup
definition is an acceptable way of providing 12.0 by now. An ideal way would be to write a program to analyze the (complex) dependencies of Mathematica and auto-generate definitions for every version, but this cannot be done easily and quickly for 12.0.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)