Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial 15-7590 #114

Merged
merged 6 commits into from Feb 4, 2020
Merged

Initial 15-7590 #114

merged 6 commits into from Feb 4, 2020

Conversation

tomberek
Copy link
Contributor

Still working out bugs with Graphics, but the Wifi only working with 5.1 is an issue that will have to be readdressed.

Mic92
Mic92 reviewed Jul 26, 2019
View reviewed changes
dell/xps/15-7590/README.wiki Outdated Show resolved Hide resolved
Mic92
Mic92 reviewed Jul 26, 2019
View reviewed changes
dell/xps/15-7590/default.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented Jul 26, 2019

Installation seems to be pretty much the same on all dell products (disable secure boot, disable raid mode). Maybe we could unify this somehow.

@Camsbury
Copy link

@tomberek let me know if you have time to close this out soon. I am coming into one of these laptops soon for work and would love to have something official in place to work from.

Mic92
Mic92 reviewed Aug 17, 2019
View reviewed changes
dell/xps/15-7590/default.nix Outdated Show resolved Hide resolved
Mic92
Mic92 reviewed Aug 17, 2019
View reviewed changes
dell/xps/15-7590/README.wiki
device = "nodev";
efiSupport = true;
efiInstallAsRemovable = true;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is either grub or systemd-boot right?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/is-anyone-using-nixos-on-dell-inspiron-7590-here/4332/3

@9999years
Copy link
Contributor

Hey folks! Also using NixOS on the 15-7590. Here's some notes from my config:

  • boot.earlyVconsoleSetup and i18n.consoleFont = "latarcyrheb-sun32" to make the boot logs a little less unreadable.
  • hardware.bumblebee.enable gets the NVIDIA drivers working for me (but I had a lot of problems with them; not sure how it got resolved but there's nothing in my config other than that line).
  • The EFI partition is really small (like, 200mb or something?) and got filled up when I upgraded the kernel to get WiFi drivers working. Might be worth putting a commented-out boot.loader.grub.configurationLimit = 10 in the config to save someone else the pain of getting out of that situation.
  • services.xserver.dpi = 175 seems to be a decent value, but I haven't bothered to do the actual calculation.

@Mic92
Copy link
Member

Mic92 commented Jan 22, 2020

Hey folks! Also using NixOS on the 15-7590. Here's some notes from my config:

* `boot.earlyVconsoleSetup` and `i18n.consoleFont = "latarcyrheb-sun32"` to make the boot logs a little less unreadable.

* `hardware.bumblebee.enable` gets the NVIDIA drivers working for me (but I _had_ a lot of problems with them; not sure how it got resolved but there's nothing in my config other than that line).

* The EFI partition is really small (like, 200mb or something?) and got filled up when I upgraded the kernel to get WiFi drivers working. Might be worth putting a commented-out `boot.loader.grub.configurationLimit = 10` in the config to save someone else the pain of getting out of that situation.

* `services.xserver.dpi = 175` seems to be a decent value, but I haven't bothered to do the actual calculation.

You can also take this PR and add your changes if you want.

@jonringer
Copy link

@Mic92 do you mind providing an example PR?

Mic92
Mic92 reviewed Feb 4, 2020
View reviewed changes
dell/xps/15-7590/default.nix
# boot.loader.efi.canTouchEfiVariables = lib.mkDefault true;

# Earlier font-size setup
console.earlySetup = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will later factor this out into an high DPI module.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.earlySetup is only valid in NixOS 20.03 onward; in 19.09 it's named console.earlySetup. Can we make it work for both versions, at least until NixOS 20.03 is stable?

Something like this should do it, I think:

  # ...
} // (if lib.versionAtLeast (lib.versions.majorMinor lib.version) "20.03"
      then { console.earlySetup = true; }
      else { boot.earlyVconsoleSetup = true; })

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9999years yes. Just make a PR.

@Mic92 Mic92 merged commit cc7140b into NixOS:master Feb 4, 2020
9999years added a commit to 9999years/nixos-hardware that referenced this pull request Feb 7, 2020
@9999years
Support NixOS 19.09 for <dell/xps/15-7590>
a4eac14 
Virtual console options were renamed in 20.03; use `console.earlySetup`
or `boot.earlyVconsoleSetup` depending on OS version.

NixOS#114 (comment)
@9999years 9999years mentioned this pull request Feb 7, 2020
Merged
rycee
rycee reviewed Feb 7, 2020
View reviewed changes
dell/xps/15-7590/default.nix
# The 48.ucode causes the Killer wifi card to crash.
# The iwlfwifi-cc-a0-46.ucode works perfectly
nixpkgs.pkgs = import <nixpkgs> {
config.allowUnfree = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a bad idea. It could cause somebody to unknowingly install unfree software.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have an option better suited for that called hardware.enableRedistributableFirmware.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see: #143

rycee
rycee reviewed Feb 7, 2020
View reviewed changes
dell/xps/15-7590/default.nix

# The 48.ucode causes the Killer wifi card to crash.
# The iwlfwifi-cc-a0-46.ucode works perfectly
nixpkgs.pkgs = import <nixpkgs> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this prevent the user from specifying their own nixpkgs.config options or doing cross platform builds of the configuration? I guess it may also interfere if you are deploying this configuration using nixops.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see: #143

Mic92 pushed a commit that referenced this pull request Feb 18, 2020
@9999years
Support NixOS 19.09 for <dell/xps/15-7590> (#141)
74efa57 
Virtual console options were renamed in 20.03; use `console.earlySetup`
or `boot.earlyVconsoleSetup` depending on OS version.

#114 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@Mic92 Mic92 Mic92 left review comments

@rycee rycee rycee left review comments

@Camsbury Camsbury Camsbury left review comments

@9999years 9999years 9999years left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tomberek @Mic92 @Camsbury @nixos-discourse @9999years @jonringer @matthewbauer @rycee