Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphene-hardened-malloc: 190405.003.2019.04.01.19 -> 1 #65021

Merged
merged 1 commit into from Jul 19, 2019

Conversation

joachifm
Copy link
Contributor

The initial stable standalone release.

The integer numbered tags are the standalone releases, while the
PQ3B.190705.003.2019.07.01.21 style tags are part of GrapheneOS releases.

For us it probably makes the most sense to track the standalone releases.

Note that the install check phase currently fails, so this is WIP. It's a little unclear to me that the install check phase is all that useful, does it really uncover problems in the packaging or upstream bugs? It seems to me primarily the latter. @risicle thoughts on this?

@risicle
Copy link
Contributor

risicle commented Jul 18, 2019

Wherever the bug was, I wanted to make sure this library was having an effect, because this is exactly the sort of thing which would easily be able to fail silently and could be doing bugger all for years without anyone noticing. And that could be for any reason from mis-compilation to the wrapper shell script being installed stupidly.

I'm not quite in a position to test this right this second, so I can't say much more about the failure right now...

@risicle
Copy link
Contributor

risicle commented Jul 18, 2019

Ok - it works if you just add eight_byte_overflow_large to the rm statement following "these tests don't actually appear to generate overflows currently". At least this way we have a record of which things are and aren't triggering aborts.

@risicle
Copy link
Contributor

risicle commented Jul 18, 2019

While you're at it, how about adding separateDebugInfo = true; to the derivation? It's the sort of thing I overlook spending so much time in the python world.

The initial stable standalone release.

The integer numbered tags are the standalone releases, while the
PQ3B.190705.003.2019.07.01.21 style tags are part of GrapheneOS releases.

For us it probably makes the most sense to track the standalone releases.
@joachifm
Copy link
Contributor Author

@risicle thank you

@joachifm
Copy link
Contributor Author

@GrahamcOfBorg build graphene-hardened-malloc

@joachifm
Copy link
Contributor Author

@GrahamcOfBorg test hardened

@joachifm joachifm merged commit 75a3bf5 into NixOS:master Jul 19, 2019
@joachifm joachifm deleted the graphene-hardened-malloc branch July 19, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants