Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtcreator: 4.6.2 -> 4.9.1 #62307

Merged
merged 2 commits into from Jun 2, 2019
Merged

qtcreator: 4.6.2 -> 4.9.1 #62307

merged 2 commits into from Jun 2, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 31, 2019

Motivation for this change

https://blog.qt.io/blog/2019/05/28/qt-creator-4-9-1-released/

Appears to work! However overall integration (ability to find/generate
compilers and such) requires a bit of hand-holding for now.
This is likely the same with the currently packaged version,
but just mentioning in case that's unexpected :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

Already built that locally. Currently trying to build a simple QT application with it. If that seems fine, I'd merge that into master :)

@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

After instaling QT, CMake and configuring a local device for the "Desktop" profile I managed to get a simple QT application running as well...

@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

Regarding the aarch64 build failure: it seems as botan isn't used anymore, hence we can remove the patch. I'll push a fix, let's see if aarch64 continues to build :)

@Ma27
qtcreator: drop obsolete aarch64 patch
b70dfba 
It seems as `botan` isn't used anymore, so the patch is obsolete now.
@Ma27

This comment has been minimized.

Sign in to view
@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

@GrahamcOfBorg build qtcreator

@Ma27
Copy link
Member

Ma27 commented Jun 2, 2019

Everything appears to evaluate and aarch64 should be fixed by now.

@Ma27 Ma27 merged commit 56a1877 into NixOS:master Jun 2, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 2, 2019

@dtzWill thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @Ma27