-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsodium: 1.0.17 -> 1.0.18 #62304
libsodium: 1.0.17 -> 1.0.18 #62304
Conversation
With CUPS v2.3b5, the configuration directive `SetEnv` moved from `cupsd.conf` to `cups-files.conf`. See also apple/cups@d47f6ae . We have to follow up as `SetEnv` is now ignored in `cupsd.conf`. Without this, executables called by cups can't find other executables they depend on, like `gs` or `perl`.
Adds closure size for seemingly no reason
… false' they can be used by remote desktop software, without X11 running locally
`alembic`[1] is a database migration tool which is invoked from the CLI when installing the telegram bridge, but never needed during the runtime. The reason why `alembic` is required here is to ensure that it exists in the Python environment when deploying the bridge. However `alembic` requires `mautrix-telegram` in its environment to create a database schema from the Python models. Such a dependency relation may be possible with tools like virtualenv, however it'll result in an infinite recursion at evaluation time in Nix. With this patch, `mautrix-telegram` doesn't depend on `alembic` anymore and provides a patched alembic (`pkgs.mautrix-telegram.alembic`) which has `mautrix-telegram` in its path. [1] https://alembic.sqlalchemy.org/en/latest/
It's the same package twice but cpp-gsl is older.
Because nesting.clone calls 'eval-config.nix' manually, without the 'extraArgs' argument that provides the 'nodes' argument to nixos modules in nixos tests, evaluating of 'nesting.clone' definitions would fail with the following error while evaluating the module argument `nodes' in "<redacted>" while evaluating the attribute '_module.args.nodes' at undefined position: attribute 'nodes' missing, at <redacted./nixpkgs/lib/modules.nix:163:28 by not using 'extraArgs' but a nixos module instead, the nodes parameter gets propagated to the 'eval-config.nix' call that 'nesting.clone' makes too - getting rid of the error. See https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/activation/top-level.nix#L13-L23 See https://github.com/NixOS/nixpkgs/blob/master/nixos/lib/build-vms.nix#L27 See NixOS#20886 (comment)
This is actually very useful. Allows you to test switch-to-configuration nesting.children is still currently still broken as it will throw away 'too much' of the config, including the modules that make nixos tests work in the first place. But that's something for another time.
Fails to build with llvm7
Without the applied patch libcanberra assumes the display is an X11 display and subsequently crashes on wayland.
pythonPackages.accupy: init at 0.1.4
pythonPackages.salmon-mail: 3.1.0 -> 3.1.1
pythonPackages.pysptk: init at 0.1.16
This reverts commit c4bc3e1, because it is working well on my macOS 10.13 system.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Pollutes git status
skaffold: 0.29.0 -> 0.30.0
yubikey-manager-gui: revert part of 2e359d9
halide: fix to llvm6
openimageio2: init at 2.0.8
…ilover postgresqlPackages.pg_auto_failover: init at 1.0.2
Are you sure about the branch, though? |
Oh, yikes, rebuilds are higher than I expected/realized. Definitely staging first, don't believe anything critical here so that seems pretty clearly not appropriate for master :). Sorry for missing that, thanks! |
Sigh. Wish github had a UI for rebase --onto or someting O:). Anyway sorry for the above madness. Looks like this is already on staging, so all is well and nothing more to do here I think! Thanks for the feedback regardless! <3 |
@dtzWill I think |
«Wish that GitHub would have a consistent or at least working UI for any of the obviously needed features» — oh well |
Motivation for this change
https://github.com/jedisct1/libsodium/releases/tag/1.0.18-RELEASE
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)