Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsodium: 1.0.17 -> 1.0.18 #62304

Closed
wants to merge 146 commits into from
Closed

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 31, 2019

Motivation for this change

https://github.com/jedisct1/libsodium/releases/tag/1.0.18-RELEASE

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Yarny0 and others added 30 commits April 5, 2019 14:23
With CUPS v2.3b5, the configuration directive `SetEnv`
moved from `cupsd.conf` to `cups-files.conf`.  See also
apple/cups@d47f6ae .

We have to follow up as `SetEnv` is now ignored in `cupsd.conf`.
Without this, executables called by cups
can't find other executables they depend on,
like `gs` or `perl`.

Verified

This commit was signed with the committer’s verified signature.
Adds closure size for seemingly no reason
… false'

they can be used by remote desktop software, without X11 running locally

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
costrouc Christopher Ostrouchov

Verified

This commit was signed with the committer’s verified signature.
costrouc Christopher Ostrouchov

Verified

This commit was signed with the committer’s verified signature.
costrouc Christopher Ostrouchov

Verified

This commit was signed with the committer’s verified signature.
costrouc Christopher Ostrouchov

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
`alembic`[1] is a database migration tool which is invoked from the CLI
when installing the telegram bridge, but never needed during the
runtime.

The reason why `alembic` is required here is to ensure that it
exists in the Python environment when deploying the bridge. However
`alembic` requires `mautrix-telegram` in its environment to create a
database schema from the Python models.

Such a dependency relation may be possible with tools like virtualenv,
however it'll result in an infinite recursion at evaluation time in Nix.

With this patch, `mautrix-telegram` doesn't depend on `alembic` anymore
and provides a patched alembic (`pkgs.mautrix-telegram.alembic`) which
has `mautrix-telegram` in its path.

[1] https://alembic.sqlalchemy.org/en/latest/

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
It's the same package twice but cpp-gsl is older.
Because nesting.clone calls 'eval-config.nix' manually,
without the 'extraArgs' argument that provides the 'nodes'
argument to nixos modules in nixos tests, evaluating
of 'nesting.clone' definitions would fail with the following error

while evaluating the module argument `nodes' in "<redacted>"
while evaluating the attribute '_module.args.nodes' at undefined position:
attribute 'nodes' missing, at <redacted./nixpkgs/lib/modules.nix:163:28

by not using 'extraArgs' but a nixos module instead, the nodes parameter
gets propagated to the 'eval-config.nix' call that  'nesting.clone'
makes too -  getting rid of the error.

See  https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/activation/top-level.nix#L13-L23
See  https://github.com/NixOS/nixpkgs/blob/master/nixos/lib/build-vms.nix#L27
See  NixOS#20886 (comment)
This is actually very useful. Allows you to test switch-to-configuration

nesting.children is still currently still broken as it will throw
away 'too much' of the config, including the modules that make
nixos tests work in the first place. But that's something for
another time.

Verified

This commit was signed with the committer’s verified signature.
dywedir Vlad M.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was signed with the committer’s verified signature.
markuskowa Markus Kowalewski
Fails to build with llvm7

Verified

This commit was signed with the committer’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
jollheef Mikhail Klementev

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
Without the applied patch libcanberra assumes the display is an X11
display and subsequently crashes on wayland.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
marsam and others added 15 commits May 31, 2019 00:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
pythonPackages.accupy: init at 0.1.4

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
pythonPackages.salmon-mail: 3.1.0 -> 3.1.1

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
pythonPackages.pysptk: init at 0.1.16

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jwiegley John Wiegley
This reverts commit c4bc3e1, because it
is working well on my macOS 10.13 system.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vdemeester Vincent Demeester
Signed-off-by: Vincent Demeester <vincent@sbr.pm>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
skaffold: 0.29.0 -> 0.30.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
yubikey-manager-gui: revert part of 2e359d9

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
halide: fix to llvm6

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
openimageio2: init at 2.0.8

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ilover

postgresqlPackages.pg_auto_failover: init at 1.0.2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
@7c6f434c
Copy link
Member

7c6f434c commented Jun 1, 2019

Are you sure about the branch, though?

@dtzWill
Copy link
Member Author

dtzWill commented Jun 1, 2019

Oh, yikes, rebuilds are higher than I expected/realized. Definitely staging first, don't believe anything critical here so that seems pretty clearly not appropriate for master :). Sorry for missing that, thanks!

@dtzWill dtzWill changed the base branch from master to staging June 1, 2019 10:27
@dtzWill dtzWill changed the base branch from staging to master June 1, 2019 10:28
@dtzWill dtzWill changed the base branch from master to staging June 1, 2019 10:28
@dtzWill
Copy link
Member Author

dtzWill commented Jun 1, 2019

Sigh. Wish github had a UI for rebase --onto or someting O:). Anyway sorry for the above madness.

Looks like this is already on staging, so all is well and nothing more to do here I think!

Thanks for the feedback regardless! <3

@dtzWill dtzWill closed this Jun 1, 2019
@dtzWill dtzWill deleted the update/libsodium-1.0.18 branch June 1, 2019 10:32
@7c6f434c
Copy link
Member

7c6f434c commented Jun 1, 2019

@dtzWill I think libsodium aims to be «the default choice when you need crypto and sane defaults but nothing fancy», and they are succeeding in selling this narrative… so — a lot of rev-deps.

@7c6f434c
Copy link
Member

7c6f434c commented Jun 1, 2019

«Wish that GitHub would have a consistent or at least working UI for any of the obviously needed features» — oh well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet