Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcanberra: add patch to stop crashing on wayland #62184

Merged
merged 1 commit into from May 30, 2019
Merged

libcanberra: add patch to stop crashing on wayland #62184

merged 1 commit into from May 30, 2019

Conversation

andir
Copy link
Member

@andir andir commented May 29, 2019

Motivation for this change

Without the applied patch libcanberra assumes the display is an X11
display and subsequently crashes on wayland.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
libcanberra: add patch to stop crashing on wayland
0202d6d 
Without the applied patch libcanberra assumes the display is an X11
display and subsequently crashes on wayland.
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build libcanberra

@worldofpeace
Copy link
Contributor

darwin failure with ofborg looks really unrelated (but not good either 🤣 ).

@worldofpeace worldofpeace merged commit d07364d into NixOS:master May 30, 2019
@worldofpeace worldofpeace mentioned this pull request May 30, 2019
Closed
10 tasks
@andir andir deleted the libcanberra-wayland branch May 30, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @worldofpeace