Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2fsprogs: 1.45.1 -> 1.45.2 #62189

Merged
merged 1 commit into from Jun 4, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 29, 2019

Motivation for this change

http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.45.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

Build failure seems to be in dependency, shadow ? o_O that's something I don't expect to remain in the failing state for long... :)

@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

(rebasing to latest staging to see if problem has been resolved....)

@dtzWill
Copy link
Member Author

dtzWill commented Jun 4, 2019

Darwin still broken on some early build, looks good elsewhere and for at least basic usage works as expected on my machines.

@dtzWill dtzWill merged commit 8ef8fd0 into NixOS:staging Jun 4, 2019
@dtzWill dtzWill deleted the update/e2fsprogs-1.45.2 branch June 4, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant