Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: 2.3.1 -> 2.5.0 #62196

Merged
merged 1 commit into from May 31, 2019
Merged

harfbuzz: 2.3.1 -> 2.5.0 #62196

merged 1 commit into from May 31, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 29, 2019

Motivation for this change

We skipped 2.4.0 due to upstream repeatedly (!) changing the tarball,
hopefully that's over now :3.

https://github.com/harfbuzz/harfbuzz/releases/tag/2.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra May 29, 2019 03:14
@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

Been working well here, glad for the upgrade! Darwin failure is in much earlier dependency, handing off to builders that will see it through :).

@dtzWill dtzWill merged commit 9b65cb1 into NixOS:staging May 31, 2019
@dtzWill dtzWill deleted the update/harfbuzz-2.5.0 branch May 31, 2019 04:12
@dtzWill dtzWill mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dtzWill