Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi-pass: refactor add new optional dependency pass-otp #62218

Merged
merged 1 commit into from May 30, 2019
Merged

rofi-pass: refactor add new optional dependency pass-otp #62218

merged 1 commit into from May 30, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

Rofi-pass as of a year ago added support for OTP passwords. This
dependency is "optional" but extremely nice to have as a default.

https://github.com/carnager/rofi-pass#requirements

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
rofi-pass: refactor add new optional dependency pass-otp
2623df3 
Rofi-pass as of a year ago added support for OTP passwords. This
dependency is "optional" but extremely nice to have as a default.

https://github.com/carnager/rofi-pass#requirements
@costrouc
Copy link
Member Author

Question: should pass-otp be optional with a flag in the function arguments?

@ofborg ofborg bot requested review from the-kenny and garbas May 29, 2019 14:22
@Ma27
Copy link
Member

Ma27 commented May 30, 2019

Built and tested locally 👍

According to nix path-info -S the closure size increased from 370.3M to 370.7M which is IMHO neglectable for an application geared to desktop use which isn't installed by default on every NixOS system.

@Ma27 Ma27 merged commit 479d161 into NixOS:master May 30, 2019
@costrouc
Copy link
Member Author

Thanks for sharing the command that you used to calculate the closure size. I will make sure to look at this in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costrouc @Ma27