Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase,keybase-gui: 3.2.2 -> 4.0.0 #62220

Merged
merged 1 commit into from Jun 4, 2019
Merged

keybase,keybase-gui: 3.2.2 -> 4.0.0 #62220

merged 1 commit into from Jun 4, 2019

Conversation

madjar
Copy link
Member

@madjar madjar commented May 29, 2019

Motivation for this change

Upgrade keybase to 4.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggPeti
Copy link
Member

ggPeti commented May 29, 2019

Doesn't build on Mojave.
image

@madjar
Copy link
Member Author

madjar commented Jun 4, 2019 •
edited

Mmmm, I'm not able to reproduce on Mojave (10.14.5). I'm not sure what the difference could be.

The path that is mentioned here does on exist on my system either, but keybase does not seem to call for it.

@ggPeti
Copy link
Member

ggPeti commented Jun 4, 2019

Sorry, my bad. I was building from the wrong commit. It builds and works correctly.
image
Btw, why is the result called result-bin?

@madjar
Copy link
Member Author

madjar commented Jun 4, 2019 •
edited

I think it might be because buildGoPackage defines multiple outputs (outputs = [ "bin" "out" ]; in https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/go-packages/generic/default.nix#L232), and the binary ends up in the bin one, which gets the result-bin symlink. I assume if we were building a go library, the library parts would end up in out (symlinked in result).

Shall we merge this?

@ggPeti
Copy link
Member

ggPeti commented Jun 4, 2019 •
edited

I support that motion. I don't have push access though. Yet.

@madjar madjar merged commit 537d213 into NixOS:master Jun 4, 2019
@madjar madjar deleted the keybase-4.0.0 branch June 4, 2019 15:01
@das-g das-g mentioned this pull request Jul 6, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madjar @ggPeti