Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.99.5.1 -> 0.99.5.2 #62310

Merged
merged 1 commit into from May 31, 2019
Merged

matrix-synapse: 0.99.5.1 -> 0.99.5.2 #62310

merged 1 commit into from May 31, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented May 31, 2019

Motivation for this change

0.99.5.2 contains a critical performance fix following a regression that was introduced in 0.99.5. Affected servers will have experienced increased CPU and RAM usage with a knock on effect of generally sluggish performance.
[…]
Please upgrade asap.
– https://matrix.org/blog/2019/05/30/synapse-0-99-5-2-released

Untested.

Note: the previous commit contained a typo in its message (0.95.5.1 instead of 0.99.5.1).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC package maintainers: @Ralith @roblabla @Ekleog

@ofborg ofborg bot requested a review from Ekleog May 31, 2019 14:31
@fpletz
Copy link
Member

fpletz commented May 31, 2019

@GrahamcOfBorg test matrix-synapse

@fpletz fpletz merged commit d1e4fcd into NixOS:master May 31, 2019
@nyanloutre
Copy link
Member

could this be cherry-picked in 19.03 ?

@rycee
Copy link
Member

rycee commented Jun 3, 2019

I've cherry-picked to release-19.03 now, been running this version on 19.03 without issues for a day or two.

@fpletz
Copy link
Member

fpletz commented Jun 4, 2019

Thanks! I was also testing this on 19.03 and was going to. 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @fpletz @nyanloutre @rycee