Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flexget: fix build #62258

Merged
merged 4 commits into from Jun 2, 2019
Merged

flexget: fix build #62258

merged 4 commits into from Jun 2, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 30, 2019

Motivation for this change

Flexget uses zxcvbn-python instead of zxcvbn. Fixes #62110

cc: @sjau

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner May 30, 2019 13:19
worldofpeace
worldofpeace reviewed Jun 1, 2019
View reviewed changes
pkgs/development/python-modules/zxcvbn/default.nix Outdated
sha256 = "151bd816817e645e9064c354b13544f85137ea3320ca3be1fb6873ea75ef7dc1";
};

# No tests in archive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have tests from github like before?

worldofpeace
worldofpeace approved these changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes build 👍

Ma27
Ma27 reviewed Jun 1, 2019
View reviewed changes
pkgs/development/python-modules/zxcvbn/default.nix Outdated
};

# No tests in archive
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible to use the GitHub archive here to have a running test suite?

@worldofpeace
Copy link
Contributor

Lol, it's the hive mind of python packages maintainers who really like to enable tests 😄

@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

Ouch, seems as my browser is really trolling me today, sorry for the duplicated comment...

@worldofpeace
Copy link
Contributor

Ouch, seems as my browser is really trolling me today, sorry for the duplicated comment...

I have that same problem. Usually hard refreshing does the trick.

@sjau
Copy link

sjau commented Jun 1, 2019

Just as question: Since there's already flexget 2.21.2, wouldn't it be better to also use that?

@marsam
Copy link
Contributor Author

marsam commented Jun 2, 2019

@worldofpeace, @Ma27 I've updated zxcvbn to use GitHub archive
@sjau I've updated to flexget 2.21.2 :)

@sjau
Copy link

sjau commented Jun 2, 2019

looks good to me.

@worldofpeace worldofpeace merged commit 43311f4 into NixOS:master Jun 2, 2019
@worldofpeace
Copy link
Contributor

Thanks for fixing this @marsam ✨

Likewise to everyone.
(always thank yourself too)

@marsam marsam deleted the fix-flexget branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
4 participants
@marsam @worldofpeace @Ma27 @sjau