conmon: 0.0.1pre52_6905a4d -> 0.2.0 #62213
Conversation
|
|
||
| nativeBuildInputs = [ git pkgconfig ]; | ||
| buildInputs = [ glib systemd ] ++ | ||
| stdenv.lib.optionals (glibc != null) [ glibc glibc.static ]; |
There was a problem hiding this comment.
What's the intent of checking if glibc is null? Why do we now need the glibc.static input? I assume you 1) want to make the binary static (which I suppose is fine, but should be handled with a flag IMO anyway or simply enabled unilaterally in all cases with a justification), or 2) make this buildable with Musl (but that won't be possible with this change anyway AFAICS, because the systemd buildInput is incompatible with musl as the libc. You really should instead be using pkgsCross or pkgsMusl to use musl as the libc on your end as a nixpkgs user, and this expression should instead check stdenv.hostPlatform.isMusl to conditionally include things in the buildInputs or not)
There was a problem hiding this comment.
The main reason behind this is to build it with musl libc and I managed to get systemd (or just the library part) to be built with musl. I changed the optional to stdenv.hostPlatform.isMusl.
|
Thanks for the valuable feedback @thoughtpolice, I appreciate it! One discussion point seems still open for me, where I'm not sure if the implementation is correct. PTAL. |
|
@thoughtpolice @vdemeester A friendly ping to not forget about me :) |
|
@saschagrunert Sorry for the delay -- please see one final nit, I think it might have just been a simple typo! |
Update conmon to v0.2.0 and move it into a dedicated package. Since we are now using conmon as dedicated package, cri-o does not need to built it, too. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
|
Alright thanks, I fixed the mentioned issue. :) PTAL |
|
@GrahamcOfBorg build conmon |
|
@saschagrunert Done, sorry for the delay on this! If I have any changes to make later on I'll follow up with my own PR and cc you. |
Update conmon to v0.2.0 and move it into a dedicated package. Since we
are now using conmon as dedicated package, cri-o does not need to built
it, too.
cc @vdemeester @thoughtpolice