Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zeroing out logic in modifySoname #171

Merged
merged 1 commit into from Jun 3, 2020

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented May 29, 2019

The original SONAME is filled with 'X' characters in the modifySoname
function. This can cause issues if the .dynstr entry is still referenced
in other sections, e.g. some libraries use the SONAME entry as version
specifiers.

Closes: #155

The original SONAME is filled with 'X' characters in the modifySoname
function. This can cause issues if the .dynstr entry is still referenced
in other sections, e.g. some libraries use the SONAME entry as version
specifiers.
@DelightRun
Copy link

Why has this PR still not been accepted?

lkollar added a commit to lkollar/manylinux that referenced this pull request Apr 17, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
lkollar added a commit to lkollar/manylinux that referenced this pull request Apr 18, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
lkollar added a commit to lkollar/manylinux that referenced this pull request Apr 18, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
lkollar added a commit to lkollar/manylinux that referenced this pull request Apr 18, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
lkollar added a commit to lkollar/manylinux that referenced this pull request Apr 18, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
lkollar added a commit to lkollar/manylinux that referenced this pull request Apr 24, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
lkollar added a commit to lkollar/manylinux that referenced this pull request Apr 24, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
mayeut pushed a commit to pypa/manylinux that referenced this pull request Apr 25, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
grzanka pushed a commit to grzanka/manylinux that referenced this pull request May 20, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
@domenkozar
Copy link
Member

@lkollar I think I can help you get this merged if you provide a test case and a bit more explanations why that part of the code is not needed anymore.

@domenkozar
Copy link
Member

Seems like this was added in 764dacc, @darealshinji could you take a look what was the reasoning for zeroing out soname?

@domenkozar
Copy link
Member

Given that this patch is widely used, let's just merge it.

@domenkozar domenkozar merged commit 4aff679 into NixOS:master Jun 3, 2020
rdb pushed a commit to panda3d/manylinux that referenced this pull request Sep 14, 2020
This patch is a copy of the upstream PR
NixOS/patchelf#171. This fixes a bug in patchelf
which causes an SONAME entry filled with 'X' values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--set-soname corrupts binary if the original soname string is also used for symbol versioning
3 participants