Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pulseaudio: Set speex-float-5 as default resample-method #62315

Merged
merged 2 commits into from
Jun 10, 2019
Merged

nixos/pulseaudio: Set speex-float-5 as default resample-method #62315

merged 2 commits into from
Jun 10, 2019
+10 −0

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 31, 2019 •
edited
Loading

The upstream default (speex-float-1) results in audible artifacts

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@adisbladis
nixos/pulseaudio: Set speex-float-5 as default resample-method

Verified

This commit was signed with the committer’s verified signature. The key has expired.
kalbasit Wael Nasreddine
GPG key ID: FD437548E0BF0F5F
Expired
Verified
Learn about vigilant mode
b19e838 
The upstream default (speex-float-1) results in audible artifacts
@adisbladis adisbladis requested a review from worldofpeace May 31, 2019 15:06
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 31, 2019
@worldofpeace
Copy link
Contributor

Seems there is a reason why they've left this at 1

Also

https://lists.freedesktop.org/archives/pulseaudio-discuss/2014-August/021362.html
It's quite sad that the current default in PulseAudio was influenced by
the needs of low-power embedded devices at the measurable expense of the
sound quality on the typical desktop. Now, with plots, figures and
knowledge in hand, we can fix it.

worldofpeace
worldofpeace approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never particularly cared for this default and had it at speex-float-5 anyway.
(like many of their defaults 😄 )

It's a good choice, at the cost of low powered embedded devices.

fpletz
fpletz approved these changes Jun 1, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @worldofpeace. Thanks for the links!

Since we support running NixOS on low-end ARM hardware, I suggest we mention this change in the release notes though.

@worldofpeace
Copy link
Contributor

Since we support running NixOS on low-end ARM hardware, I suggest we mention this change in the release notes though.

Sounds good.

@worldofpeace worldofpeace force-pushed the pulseaudio/resample-method branch from ad818f8 to 29cc54c Compare June 6, 2019 22:50
@worldofpeace
Copy link
Contributor

Added a release note.

@ofborg ofborg bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Jun 6, 2019
@adisbladis adisbladis merged commit 32b374f into NixOS:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @worldofpeace @fpletz