Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/pulseaudio: Set speex-float-5 as default resample-method #62315

Merged
merged 2 commits into from Jun 10, 2019

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 31, 2019

The upstream default (speex-float-1) results in audible artifacts

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The upstream default (speex-float-1) results in audible artifacts
@worldofpeace
Copy link
Contributor

Seems there is a reason why they've left this at 1

Also

https://lists.freedesktop.org/archives/pulseaudio-discuss/2014-August/021362.html
It's quite sad that the current default in PulseAudio was influenced by
the needs of low-power embedded devices at the measurable expense of the
sound quality on the typical desktop. Now, with plots, figures and
knowledge in hand, we can fix it.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never particularly cared for this default and had it at speex-float-5 anyway.
(like many of their defaults 😄 )

It's a good choice, at the cost of low powered embedded devices.

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @worldofpeace. Thanks for the links!

Since we support running NixOS on low-end ARM hardware, I suggest we mention this change in the release notes though.

@worldofpeace
Copy link
Contributor

Since we support running NixOS on low-end ARM hardware, I suggest we mention this change in the release notes though.

Sounds good.

@worldofpeace
Copy link
Contributor

Added a release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants