Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.gruvbox-community: init at 2019-05-31 #62259

Merged
merged 1 commit into from May 31, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

The original Gruvbox colorscheme has gone unmaintained for a while. A new fork has been made recently and already has good number of fixes and merged PRs. Since it is pretty hard to have breaking changes with a colorscheme, it seemed logical to me to push it to nixpkgs ^^

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented May 31, 2019

Breaking changes are not the only consideration, there is also trust. People may have vetted gruvbox and put their trust in its author. Silently changing who is in control of the gruvbox package may be problematic, especially if its a relatively recent fork (not big community support / review yet) and its not entirely clear who is behind it.

I'm not sure if it is easily possible with the current non-namespaced vim plugin infrastructure, but I'd prefer this to be added as a separate plugin (gruvbox-community or something).

@minijackson minijackson changed the title vimPlugins.gruvbox: change to gruvbox-community's fork vimPlugins.gruvbox-community: init at 2019-05-31 May 31, 2019
@minijackson
Copy link
Member Author

Great comment! Since I don't think you can rename plugins in vim-plugin-names, I've added it in overrides.nix for now, I'll see if there is a better way to do this in the meantime ^^

@timokau
Copy link
Member

timokau commented May 31, 2019

I don't see any reason to hold this back for now, but keep in mind that the plugin won't be included in automatic updates. If you find the time, it'd be nice to add renaming ability to update.py (having lines such as gruvbox-community/community as gruvbox-community in vim-plugin-names).

Thanks for the contribution :)

@timokau timokau merged commit 310a1ec into NixOS:master May 31, 2019
@minijackson minijackson deleted the gruvbox-community branch September 14, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants