Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubikey-manager-gui: revert part of 2e359d9 #62261

Merged
merged 1 commit into from May 31, 2019
Merged

yubikey-manager-gui: revert part of 2e359d9 #62261

merged 1 commit into from May 31, 2019

Conversation

bricewge
Copy link
Contributor

@bricewge bricewge commented May 30, 2019 •
edited

Motivation for this change

Fixes #62210 by reverting part of 2e359d9.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 I would like your take on this since you cleaned up #55587 with the aforementioned commit.

@avdv
Copy link
Member

avdv commented May 31, 2019

Hi, @bricewge.

Looks good to me. I guess the paths are needed since dynamically loaded runtime dependencies cannot be determined automatically. @Ma27 what do you think?

avdv
avdv approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mic92 Mic92 merged commit 0c6fb79 into NixOS:master May 31, 2019
@bricewge bricewge deleted the ykman-gui-otp branch May 31, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@avdv avdv avdv approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yubico-manager-qt can't find ykpers lib
3 participants
@bricewge @avdv @Mic92