Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.strict-rfc3339: init at 0.7 #62313

Closed
wants to merge 1 commit into from
Closed

pythonPackages.strict-rfc3339: init at 0.7 #62313

wants to merge 1 commit into from

Conversation

vanschelven
Copy link
Contributor

Motivation for this change

Adds a useful python package (that also happens to be a dependency of the jsonschema package, for which a separate PR will be openend soon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" there are no such packages yet
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vanschelven vanschelven requested a review from FRidh as a code owner May 31, 2019 14:22
@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 1, 2019 •
edited

that also happens to be a dependency of the jsonschema package, for which a separate PR will be openend soon

Pretty sure we already have jsonschema.

Also seems to be optional https://github.com/Julian/jsonschema/blob/master/setup.cfg#L40

@vanschelven
Copy link
Contributor Author

that also happens to be a dependency of the jsonschema package, for which a separate PR will be openend soon

Pretty sure we already have jsonschema.

Also seems to be optional https://github.com/Julian/jsonschema/blob/master/setup.cfg#L40

You are correct.

What I should have said is that, since this is an optional dependency of jsonschema, it is a dependency of packages that have jsonschema[format] as a requirement.

@worldofpeace
Copy link
Contributor

that also happens to be a dependency of the jsonschema package, for which a separate PR will be openend soon

Pretty sure we already have jsonschema.
Also seems to be optional https://github.com/Julian/jsonschema/blob/master/setup.cfg#L40

You are correct.

What I should have said is that, since this is an optional dependency of jsonschema, it is a dependency of packages that have jsonschema[format] as a requirement.

Thanks for clearing that up 👍 .

Testing if everything builds now.
@GrahamcOfBorg build pythonPackages.strict-rfc3339 python37Packages.strict-rfc3339 python36Packages.strict-rfc3339 python35Packages.strict-rfc3339

@worldofpeace
Copy link
Contributor

Thanks, merged in fcf7cac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanschelven @worldofpeace