Add structured clone tests for errors #17095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
This was referenced May 30, 2019
TimothyGu
reviewed
Jun 1, 2019
html/infrastructure/safe-passing-of-structured-data/structuredclone_0.html
Outdated
Show resolved
Hide resolved
TimothyGu
reviewed
Jun 3, 2019
html/infrastructure/safe-passing-of-structured-data/structuredclone_0.html
Show resolved
Hide resolved
TimothyGu
approved these changes
Jun 4, 2019
domenic
approved these changes
Jun 4, 2019
html/infrastructure/safe-passing-of-structured-data/structuredclone_0.html
Show resolved
Hide resolved
domenic
added a commit
that referenced
this pull request
Jun 4, 2019
Supplements #17095. Follows whatwg/html#4665 and whatwg/webidl#732.
|
Added another test, PTAL @yutakahirano |
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Jul 3, 2019
Define serialization and deserialization steps for all built-in NativeError types from the JavaScript specification. This change doesn't cover DOMExceptions, which are covered by whatwg/webidl#732. Fixes #4268. Tests: * web-platform-tests/wpt#17095 * web-platform-tests/wpt#17159
domenic
pushed a commit
to whatwg/webidl
that referenced
this pull request
Jul 3, 2019
Fixes #729. See also whatwg/html#4268. Tests: * web-platform-tests/wpt#17095 * web-platform-tests/wpt#17159
|
Going to close and reopen to try to fix the taskcluster failure. |
yutakahirano
commented
Jul 9, 2019
| assert_equals(e.data.foo, undefined, "Checking custom property"); | ||
| }); | ||
| t.step(function() { | ||
| const error = frames[0].URIError("some message"); |
There was a problem hiding this comment.
Can you check Object.getPrototypeof(error), error.constructor and error.name?
There was a problem hiding this comment.
That shouldn't be necessary in this setup step, I think? But I will add them anyway, and we can always revert.
annevk
pushed a commit
that referenced
this pull request
Jul 9, 2019
Supplements #17095. Follows whatwg/html#4665 and whatwg/webidl#732.
domenic
added a commit
that referenced
this pull request
Jul 9, 2019
Supplements #17095. Follows whatwg/html#4665 and whatwg/webidl#732.
|
Rebasing this should fix the Taskcluster failure, while just running again doesn't because the Taskcluster config from the PR branch is used and not what is on master. But admin merging instead since the failure is a known and fixed one. |
This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 --HG-- rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-iframe.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-iframe.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-worker.js => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-worker.js
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
Supplements web-platform-tests#17095. Follows whatwg/html#4665 and whatwg/webidl#732.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tests for spec changes.