Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedup: 1.0 -> 2.0 #62199

Merged
merged 2 commits into from May 30, 2019
Merged

dedup: 1.0 -> 2.0 #62199

merged 2 commits into from May 30, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 29, 2019

Motivation for this change

Update deps, enable tests.

https://git.2f30.org/dedup/file/CHANGELOG.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
dedup: 1.0 -> 2.0
7d4bfca 
Update deps, enable tests.
mmahut
mmahut requested changes May 29, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

pkgs/tools/backup/dedup/default.nix Outdated
doCheck = true;

checkInputs = [ coreutils gawk ];
checkTarget = "test";

meta = with stdenv.lib; {
description = "data deduplication program";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to CONTRIBUTING this needs to be capitalized.

@Ma27
Copy link
Member

Ma27 commented May 30, 2019

Built and tested locally as described in the project's README and fixed the description as requested by @mmahut.

Let's wait for ofborg and merge then.

@Ma27 Ma27 merged commit 65a73e0 into NixOS:master May 30, 2019
@Ma27
Copy link
Member

Ma27 commented May 30, 2019

@dtzWill @mmahut thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Ma27 @mmahut