Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: 1.1.1c, 1.0.2s #62180

Merged
merged 3 commits into from May 29, 2019
Merged

openssl: 1.1.1c, 1.0.2s #62180

merged 3 commits into from May 29, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 29, 2019

Motivation for this change

These updates are described in this message:

https://mta.openssl.org/pipermail/openssl-announce/2019-May/000150.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from peti May 29, 2019 00:25
@peti
Copy link
Member

peti commented May 29, 2019

@GrahamcOfBorg build openssl openssl_1_1

peti
peti requested changes May 29, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not compile.

@dtzWill
Copy link
Member Author

dtzWill commented May 29, 2019

Yikes, sorry! It does for me? Will fix shortly, sorry about that.

@dtzWill
Copy link
Member Author

dtzWill commented May 29, 2019

Ah, looks like staging had a CVE fix not on the branch I was testing--still building but looks better now :).

@ofborg ofborg bot requested a review from peti May 29, 2019 13:27
@peti peti merged commit cd76032 into NixOS:staging May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @peti