Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.8.1 -> 1.8.2 #62293

Merged
merged 1 commit into from May 31, 2019
Merged

gitea: 1.8.1 -> 1.8.2 #62293

merged 1 commit into from May 31, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented May 31, 2019 •
edited

Motivation for this change

Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.8.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @disassembler @kolaente @aanderse

@etu
Copy link
Contributor Author

etu commented May 31, 2019 •
edited

@GrahamcOfBorg build nixosTests.gitea

@etu etu mentioned this pull request May 31, 2019
Merged
10 tasks
aanderse
aanderse approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The darwin failure appears to be bot related so LGTM 👍

@etu
Copy link
Contributor Author

etu commented May 31, 2019 •
edited

@GrahamcOfBorg build gitea

Trying again :-)

@fpletz fpletz merged commit f86871a into NixOS:master May 31, 2019
@etu etu deleted the gitea-upgrade branch May 31, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @aanderse @fpletz