Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubstaff: 1.4.5 -> 1.4.6 #62296

Merged
merged 2 commits into from Jun 1, 2019
Merged

hubstaff: 1.4.5 -> 1.4.6 #62296

merged 2 commits into from Jun 1, 2019

Conversation

srghma
Copy link
Contributor

@srghma srghma commented May 31, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit 1b23dbe into NixOS:master Jun 1, 2019
@worldofpeace
Copy link
Contributor

Thanks @srghma

@srghma
Copy link
Contributor Author

srghma commented Jun 1, 2019

@worldofpeace np

I have a question: is there some bot that monitors nixpkgs and could periodically find and run the update.sh scripts, and if script changes some file in repo - make pr (like revision.json in case of hubstaff). Where could I submit such proposal?

@worldofpeace
Copy link
Contributor

@worldofpeace np

I have a question: is there some bot that monitors nixpkgs and could periodically find and run the update.sh scripts, and if script changes some file in repo - make pr (like revision.json in case of hubstaff). Where could I submit such proposal?

This has been sort of discussed in #50665 (comment) #50665 (comment).
Currently we have nixpkgs-update which essentially submits update prs based of data provided by repology. However I'm not sure if it supports how this expression uses revision.json.

So currently that might be a feature in nixpkgs-update's roadmap.

@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019 •
edited

Not sure if that's a good idea, but the best shot for now would be to ask here: https://github.com/ryantm/nixpkgs-update/ (this is the software behind @r-ryantm that periodically updates a large set of our packages based on repology)

Nvm, I had the tab open, but GitHub didn't reload....

@srghma
Copy link
Contributor Author

srghma commented Jun 1, 2019

made an issue ryantm/nixpkgs-update#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srghma @worldofpeace @Ma27