Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.luadbi: 0.7.1 -> 0.7.2 #62298

Closed
wants to merge 1 commit into from
Closed

luaPackages.luadbi: 0.7.1 -> 0.7.2 #62298

wants to merge 1 commit into from

Conversation

sshisk
Copy link
Contributor

@sshisk sshisk commented May 31, 2019

Fixes a nasty memory leak in Prosody.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sshisk
luaPackages.luadbi: 0.7.1 -> 0.7.2
98d1ddc 
Fixes a nasty memory leak in Prosody.
@teto
Copy link
Member

teto commented Jun 2, 2019

thanks for the update. I've some local changes for lua I would like to upstream, including moving lua-dbi to the generated packages. Will try to do it this week, else I will merge this

@teto teto mentioned this pull request Jun 4, 2019
Closed
10 tasks
@teto
Copy link
Member

teto commented Jun 9, 2019

Hi could you try my linked PR instead please ?
It seems like prosody starts fine with it which is strange since the new packages doesn't contain any of the previous buildInputs = [ mysql.client mysql.connector-c postgresql sqlite ];.
I wish you could help me check/explain how to properly test it. Ty

@teto
Copy link
Member

teto commented Jun 11, 2019 •
edited

Merged in #62964

@teto teto closed this Jun 11, 2019
@FRidh
Copy link
Member

FRidh commented Jun 11, 2019

@teto wrong reference?

@teto
Copy link
Member

teto commented Jun 11, 2019

fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sshisk @teto @FRidh