Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gparted: 0.33.0 -> 1.0.0 #62295

Merged
merged 1 commit into from May 31, 2019
Merged

gparted: 0.33.0 -> 1.0.0 #62295

merged 1 commit into from May 31, 2019

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 31, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member Author

The only thing causing the major version change is the transition from gtk2 to gtk3.

@Ma27
Copy link
Member

Ma27 commented May 31, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit fffaaae into NixOS:master May 31, 2019
@Ma27
Copy link
Member

Ma27 commented May 31, 2019

@adisbladis thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @Ma27