Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/malloc: add scudo from LLVM compiler-rt #62227

Merged
merged 1 commit into from May 29, 2019
Merged

Conversation

delroth
Copy link
Contributor

@delroth delroth commented May 29, 2019

Motivation for this change

The Scudo allocator is a good compromise between security, performance and compatibility. The GrapheneOS allocator which is currently the only "secure" allocator option in NixOS is incompatible with Nix itself (due to coping badly with tons of small allocs) and has a fairly big overhead.

Scudo doesn't go as far in terms of error checking as the Graphene allocator (Graphene is closer to ASAN/MSAN). But being able to run Nix is fairly important :-) It's around a 20% CPU time increase on some test nix evaluations I've done compared to libc malloc.

See:

@joachifm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants