nixos/malloc: add scudo from LLVM compiler-rt #62227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Scudo allocator is a good compromise between security, performance and compatibility. The GrapheneOS allocator which is currently the only "secure" allocator option in NixOS is incompatible with Nix itself (due to coping badly with tons of small allocs) and has a fairly big overhead.
Scudo doesn't go as far in terms of error checking as the Graphene allocator (Graphene is closer to ASAN/MSAN). But being able to run Nix is fairly important :-) It's around a 20% CPU time increase on some test nix evaluations I've done compared to libc malloc.
See:
@joachifm
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)